docs better indicate that state updaters shallowly merge with state#9554
Merged
sophiebits merged 1 commit intofacebook:masterfrom May 1, 2017
Merged
docs better indicate that state updaters shallowly merge with state#9554sophiebits merged 1 commit intofacebook:masterfrom
sophiebits merged 1 commit intofacebook:masterfrom
Conversation
this was a surprise to me because the docs seemed to indicate that when using an updater, the result _needed_ to be a new state object. I was [not alone](https://twitter.com/ken_wheeler/status/857939690191806464) i think in discovering this as a result of the previous tweet in the thread.
Collaborator
|
Thanks @nsfmc! |
gaearon
pushed a commit
that referenced
this pull request
May 1, 2017
…9554) this was a surprise to me because the docs seemed to indicate that when using an updater, the result _needed_ to be a new state object. I was [not alone](https://twitter.com/ken_wheeler/status/857939690191806464) i think in discovering this as a result of the previous tweet in the thread. (cherry picked from commit f737d63)
flarnie
pushed a commit
that referenced
this pull request
Jun 12, 2017
…9554) this was a surprise to me because the docs seemed to indicate that when using an updater, the result _needed_ to be a new state object. I was [not alone](https://twitter.com/ken_wheeler/status/857939690191806464) i think in discovering this as a result of the previous tweet in the thread. (cherry picked from commit f737d63)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this was a surprise to me because the docs seemed to indicate that when
using an updater, the result needed to be a new state object. I was
not alone
i think in discovering this as a result of the previous tweet in the
thread.
i'm open to wording changes and such. i debated the final sentence reading:
but it felt awkward. i think the other changes get the point across anyway, but open to suggestions.